The way you have it now, setting up the OnActorUpdate is entirely unnecessary, and doesn't really do anything. If your intent was to handle the case where the player enters the scene, then after they have entered the scene became eligible, you should move the eligibility condition to within the actor update. If you only want to check if they are eligible on ActorInit you can remove the OnActorUpdate usage

Oh, I realize now malk pointed out that you had duplicated this condition both in and out of the OnActorUpdate, looks like you just removed the wrong one

Is there a more efficient way to check that Link has an ocarina? Even if it's just a macro? I wanted to write a HAS_OCARINA macro for that check where it's either the Fairy Ocarina or the Ocarina of Time.

Is there a more efficient way to check that Link has an ocarina?

Technically you could do INV_CONTENT(ITEM_OCARINA_FAIRY) != ITEM_NONE, but it's not foolproof if the player somehow puts something else into the ocarina slot

What was the reasoning for having that as an option for the rando setting?

I don't think there was really any logic to it, I just wanted a third option. 😅

I did just have an idea of adding a third option where instead of never having to play ZL, you only have to play it once and then the waterfall stays open for the rest of the game (like the door to Darunia's room). I think that'd be more suitable for the enhancement, though.

I also see your point about having one setting override the other.

Play one time would definitely make more sense than just arbitrarily having it open as adult but not as child. That would also make sense to be able to add to the enhancement, and it wouldn't have to be accounted for in logic, I don't think.

I had a think and, fundamentally, if it's closed at all you need to play the song to open it, even if only once. So I think there's no point in having that be an option for the rando setting.

I thought of doing it for the enhancement, but that would require adding a permanent flag to set when it's opened; the one that gets set in VB is a temporary one.

Play one time would definitely make more sense than just arbitrarily having it open as adult but not as child. That would also make sense to be able to add to the enhancement, and it wouldn't have to be accounted for in logic, I don't think.

When we get OI as a trick, the ZL check will want to use Here to check for either age access, as OI can lock ocarina use by age if the player has limited items to OI with (and put away OI is off). That being said, when we do this, I would insist on play once mode. This is because it's possible to cause key logic edge cases with backflip OI and sticks, and bomb OI in general, giving you temporary access to a dungeon and I want to make a point of stamping all of those out.

This is a minor issue though and not one worth making a whole setting for like having it always open would be.

When we get OI as a trick, the ZL check will want to use Here to check for either age access, as OI can lock ocarina use by age if the player has limited items to OI with (and put away OI is off). That being said, when we do this, I would insist on play once mode. This is because it's possible to cause key logic edge cases with backflip OI and sticks, and bomb OI in general, giving you temporary access to a dungeon and I want to make a point of stamping all of those out.

What's OI?

Ocarina Items, a glitch that allows you to play an item that is not an ocarina, as an ocarina.

Worth noting that it doesn't apply to every item.
Here is some info about it.

I thought of doing it for the enhancement, but that would require adding a permanent flag to set when it's opened; the one that gets set in VB is a temporary one.

Ooh, you know what - I just discovered that there is, in fact, a permanent flag for opening Zora's Domain for the first time. It's an event flag. Tomorrow I will mod the enhancement to add the "play only once" option.

I think that flag might just be for cutscene or something, so the first time cs doesn't play every time you open it.

The owl doesn't appear at the beginning of Zora's River if the flag is set.

OK, done. I also decided to remove the owl if it's set to never play ZL, because him telling you to play it would be incorrect.

Maybe we should plug the owl removal from this into the existing cutscene skip for the owl instead of just killing where you have it? I'm not sure how that would fit in the design plan for time savers and hooks, though.

My vision with removing the owl was that the "Never play" option would work like the "Play once" option does after the waterfall is opened once, and that would include the owl being gone.

So that removal only runs on never play?

So that removal only runs on never play?

Correct.

I need some help understanding your request. Here's what I think you're asking for:

• In randomizer mode, you want the enhancement setting to be greyed out.
• In randomizer mode, if the setting for the waterfall is Closed, you want Link to only have to play ZL once to open it. If the setting is Open, he never has to play ZL.

That is correct.

Hey, sorry to come in with this after you went through the effort to follow Pepper0ni's directions, but we're not ready to implement the underlying principle behind the idea of forcing "play only once" despite the logic setting being basically off, so could I get you to only force the enhancement when the logic setting is "open"? Should be good to merge after that. So, the functionality should be:

1. Enhancement option greyed out only if logic setting is "Open" in a rando file
2. Enhancement functionality forced to open in that instance

Again, following the blue fire arrows pattern.

2. Enhancement functionality forced to open in that instance

By this I assume you mean forced to the "Never play" option?

Yes.

Finally got a playtest up and running, for some reason it looks like the forcing open isn't working

Oops, I think I know why. I removed the rando part of the hook, thinking it'd be enough to lean on the forced enhancement setting, which is still conditioned upon being at least able to play ZL. I forgot that that misses the point of having it open in rando. My bad.

Will give it a final test when conflicts are resolved

It's a little unusual to me that Never is overridden on close waterfall but the option is still selectable

The point is that only the open rando setting would override the enhancement there, otherwise it would be up to the player whether to change it or not, so unless you see something in the code that says it's overriding anything when the closed rando option is selected, I believe that's how it should be.